Merged
Conversation
Running the tests via `python -m unittest` shows several warnings which this commit fixes: - Remove use of deprecated `assertEquals` and `assertNotEquals` methods in favor of `assertEqual` and `assertNotEqual`. - Remove unclosed file objects in setup method and avoid relying on platform default file encoding. Note that there are still several other warnings, but those are emitted by libraries (e.g. deprecation warnings in werkzeug).
325e1cf to
8944ef4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Running the tests via
python -m unittestshows several warnings which this commit fixes:Remove use of deprecated
assertEqualsandassertNotEqualsmethods in favor ofassertEqualandassertNotEqual.Remove unclosed file objects in setup method and avoid relying on platform default file encoding.
Note that there are still several other warnings, but those are emitted by libraries (e.g. deprecation warnings in werkzeug).