Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make pip install during build more reliable #1270

Conversation

c-w
Copy link
Contributor

@c-w c-w commented May 7, 2018

We've been seeing a number of false-positive build breaks due to network issues when connecting to PyPI. Sample build: https://travis-ci.org/Cal-CS-61A-Staff/ok/jobs/375933342.

The recommended way to fix these issues is via retries in Travis, as per https://docs.travis-ci.com/user/common-build-problems/. Additionally, this change also increases the pip install timeout.

We've been seeing a number of false-positive build breaks due to network
issues when connecting to PyPI. Sample build:
https://travis-ci.org/Cal-CS-61A-Staff/ok/jobs/375933342.

The recommended way to fix these issues is via retries in Travis, as per
https://docs.travis-ci.com/user/common-build-problems/. Additionally,
this change also increases the pip install timeout.
@c-w c-w mentioned this pull request May 7, 2018
Copy link
Member

@colinschoen colinschoen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@colinschoen colinschoen merged commit 791cd8c into okpy:master May 7, 2018
@c-w c-w deleted the enhancement/c-w/increase-travis-build-timeout branch May 7, 2018 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants