Switch to pessimistic SQL disconnect handling #1284
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we were using optimistic disconnect handling for the database connection pool: assume that all the connections are live and recycle them before a certain timeout just in case the server kills the connections after a certain period of inactivity. This approach reduced the frequency of "MySQL went away" errors, but it turns out that it didn't eliminate them. As such, this change switches to pessimistic disconnect handling: before using a given connection, it is first tested for liveness by SQLAlchemy. This is implemented by passing `pool_pre_ping` to the `create_engine` call [1]. Note that this option was only introduced in SQLAlchemy 1.2 [2] so this change also updates the SQLAlchemy dependency to the latest release. [1] http://docs.sqlalchemy.org/en/latest/core/pooling.html#pool-disconnects-pessimistic [2] https://twitter.com/sqlalchemy/status/884415051125452802
Sumukh
approved these changes
May 31, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we were using optimistic disconnect handling for the database connection pool: assume that all the connections are live and recycle them before a certain timeout just in case the server kills the connections after a certain period of inactivity. This approach reduced the frequency of "MySQL went away" errors, but it turns out that it didn't eliminate them.
As such, this change switches to pessimistic disconnect handling: before using a given connection, it is first tested for liveness by SQLAlchemy. This is implemented by passing
pool_pre_pingto thecreate_enginecall (docs). Note that this option was only introduced in SQLAlchemy 1.2 (announcement) so this change also updates the SQLAlchemy dependency to the latest release.