Skip to content

Fix link to ARM template - #1291

Merged
colinschoen merged 3 commits into
okpy:masterfrom
c-w:bug/c-w/fix-arm-template-link
Jun 25, 2018
Merged

Fix link to ARM template#1291
colinschoen merged 3 commits into
okpy:masterfrom
c-w:bug/c-w/fix-arm-template-link

Conversation

@c-w

@c-w c-w commented Jun 25, 2018 •
edited
Loading

Copy link
Copy Markdown
Contributor

For some reason the ARM template link in the "Deploy to Azure" button and templateBaseURL were still pointing to development fork and branch. This pull request updates the ARM template links to point to the canonical upstream repository and master branch.

Also:

  • Fix a typo in the ARM template's setup of the Redis connection URI for the OKpy worker.
  • Fix the name of the AppInsights environment variable set in the ARM template.

c-w added 3 commits June 25, 2018 08:53
@c-w
Fix link to ARM templates
3e286f6 
For some reason the ARM template link in the "Deploy to Azure" button
and templateBaseURL were still pointing to development fork and branch.
This pull request updates the ARM template links to point to the
canonical upstream repository and master branch.
@c-w
Fix typo in Redis connection URI
7d06378
@c-w
Fix name of AppInsights environment variable
7ba8e0d
@c-w

c-w commented Jun 25, 2018

Copy link
Copy Markdown
Contributor Author

@marrobi FYI

@marrobi

marrobi commented Jun 25, 2018

Copy link
Copy Markdown
Contributor

Thanks @c-w . More haste less speed!

colinschoen
colinschoen approved these changes Jun 25, 2018
View reviewed changes

@colinschoen colinschoen left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@colinschoen
colinschoen merged commit b39b925 into okpy:master Jun 25, 2018
@c-w
c-w deleted the bug/c-w/fix-arm-template-link branch June 25, 2018 18:52
colinschoen added a commit that referenced this pull request Jun 26, 2018
@colinschoen
Merge branch 'master' into enhancement/colinschoen/ci-integration
122a4dd 
* master:
  Protect against set but empty OAuth variables (#1292)
  Fix link to ARM template (#1291)
  increased verbosity
  remove extraneous subtraction (#1289)
  Refactor section console controller (#1288)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@colinschoen colinschoen colinschoen approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@c-w @marrobi @colinschoen