Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix link to ARM template #1291

Merged
merged 3 commits into from Jun 25, 2018

Conversation

Projects
None yet
3 participants
@c-w
Copy link
Contributor

commented Jun 25, 2018

For some reason the ARM template link in the "Deploy to Azure" button and templateBaseURL were still pointing to development fork and branch. This pull request updates the ARM template links to point to the canonical upstream repository and master branch.

Also:

  • Fix a typo in the ARM template's setup of the Redis connection URI for the OKpy worker.
  • Fix the name of the AppInsights environment variable set in the ARM template.

c-w added some commits Jun 25, 2018

Fix link to ARM templates
For some reason the ARM template link in the "Deploy to Azure" button
and templateBaseURL were still pointing to development fork and branch.
This pull request updates the ARM template links to point to the
canonical upstream repository and master branch.
@c-w

This comment has been minimized.

Copy link
Contributor Author

commented Jun 25, 2018

@marrobi FYI

@marrobi

This comment has been minimized.

Copy link
Contributor

commented Jun 25, 2018

Thanks @c-w . More haste less speed!

@colinschoen
Copy link
Member

left a comment

LGTM

@colinschoen colinschoen merged commit b39b925 into okpy:master Jun 25, 2018

2 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@c-w c-w deleted the c-w:bug/c-w/fix-arm-template-link branch Jun 25, 2018

colinschoen added a commit that referenced this pull request Jun 26, 2018

Merge branch 'master' into enhancement/colinschoen/ci-integration
* master:
  Protect against set but empty OAuth variables (#1292)
  Fix link to ARM template (#1291)
  increased verbosity
  remove extraneous subtraction (#1289)
  Refactor section console controller (#1288)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.