Remove hard-coded links to static files #1299
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change replaces all direct links to static files (such as `/static/foo/bar`) with their equivalent `url_for` call. This introduces consistency with code that creates links to the app's Flask routes and also ensures that the links to the static files will always be correct even if the application is for example hosted at a non-root path.
Sumukh
pushed a commit
that referenced
this pull request
Jul 2, 2018
CircleCI version `1.0` is deprecated and will be start rejecting jobs on August 30th. This PR migrates our workflow to `2.0`. This loosely follows the the [1.0 -> 2.0 Migration Guide](https://circleci.com/docs/2.0/migrating-from-1-2/). This incidentally fixes the pip failures on recent CircleCI runs failing (#1299 #1301 etc) with the following error `_NamespacePath object has no attribute sort ` Signed-off-by: Colin Schoen <cschoen@berkeley.edu>
The index routes are specific to various blueprints so we can't use
`url_for('.index')` in the error pages. Passing the application root as
a global context variable to the Flask templates works around this.
Contributor
Author
|
Thanks for the review @colinschoen and the CI fixes. Build now passes. |
colinschoen
approved these changes
Jul 3, 2018
Member
colinschoen
left a comment
colinschoen
left a comment
There was a problem hiding this comment.
LGTM
Thanks for the quick fix!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change replaces all direct links to static files (such as
/static/foo/bar) with their equivalenturl_forcall. This introducesconsistency with code that creates links to the app's Flask routes and
also ensures that the links to the static files will always be correct
even if the application is for example hosted at a non-root path.