Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate Sendgrid API key during Azure setup #1311

Merged
merged 4 commits into from Jul 10, 2018

Conversation

Projects
None yet
2 participants
@c-w
Copy link
Contributor

commented Jul 10, 2018

We've been seeing some instability in production with the runtime creation of API keys approach. This is because of race conditions where one thread creates an API key and then at a later time another thread needs to re-create the key (e.g. due to the worker or pod crashing and being restarted) thus invalidating the first one.

Also:

  • Increase minimum number of pods in Azure deployment to increase availability.
  • Fix formatting in the server/utils.py file.

c-w added some commits Jul 10, 2018

Increase minimum number of pods
This increases availability of the services.
Generate Sendgrid API key during Azure setup
We've been seeing some instability in production with the runtime
creation of API keys approach. This is because of race conditions where
one thread creates an API key and then at a later time another thread
needs to re-create the key (e.g. due to the worker or pod crashing and
being restarted) thus invalidating the first one.

@c-w c-w requested a review from colinschoen Jul 10, 2018

@colinschoen
Copy link
Member

left a comment

LGTM

@colinschoen colinschoen merged commit 8f888fe into okpy:master Jul 10, 2018

3 checks passed

Travis CI - Pull Request Build Passed
Details
ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@c-w c-w deleted the c-w:bug/c-w/sendgrid-user-password-access branch Jul 10, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.