Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix download and raw buttons on Firefox #1316

Merged
merged 1 commit into from Jul 13, 2018

Conversation

Projects
None yet
2 participants
@c-w
Copy link
Contributor

commented Jul 13, 2018

On Firefox, the <button> element wrapping the <a> link swallows the
click event which leads the download and raw buttons to not perform any
action. Note that this same behavior does not reproduce on Chrome.
Switching the <button> to a <div> fixes the behavior on Firefox
while still maintaining the same styling as before and also works on
Chrome.

This issue was reported by @taupalosaurus

Fix download and raw buttons on Firefox
On Firefox, the `<button>` element wrapping the `<a>` link swallows the
click event which leads the download and raw buttons to not perform any
action. Note that this same behavior does not reproduce on Chrome.
Switching the `<button>` to a `<div>` fixes the behavior on Firefox
while still maintaining the same styling as before and also works on
Chrome.
@colinschoen
Copy link
Member

left a comment

LGTM

@colinschoen colinschoen merged commit 0cc9ef8 into master Jul 13, 2018

5 checks passed

Travis CI - Branch Build Passed
Details
Travis CI - Pull Request Build Passed
Details
ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@colinschoen colinschoen deleted the bug/c-w/download-button-firefox branch Jul 13, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.