Fix download and raw buttons on Firefox #1316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On Firefox, the `<button>` element wrapping the `<a>` link swallows the click event which leads the download and raw buttons to not perform any action. Note that this same behavior does not reproduce on Chrome. Switching the `<button>` to a `<div>` fixes the behavior on Firefox while still maintaining the same styling as before and also works on Chrome.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Firefox, the
<button>element wrapping the<a>link swallows theclick event which leads the download and raw buttons to not perform any
action. Note that this same behavior does not reproduce on Chrome.
Switching the
<button>to a<div>fixes the behavior on Firefoxwhile still maintaining the same styling as before and also works on
Chrome.
This issue was reported by @taupalosaurus