Skip to content

Enhance passing of compile options #51

Open
wants to merge 4 commits into from

4 participants

@davemerrill
  1. Support passing a subset of compile options to doT.template(). Options not passed default to values in doT.templateSettings.
  2. Add an alias for 'argnames' as a compile option, mapping it to varname. Seems appropriate, since it defines the initial arguments passed into the compiled function.

Includes a minified version built with the Google Closure Compiler on its Simple setting.
If accepted, suggest updating the page at http://olado.github.com/doT/ to mention the new options.
Didn't update the version string, figured that wasn't mine to do, but it should be done if accepted.

And please excuse and enlighten me if I'm out of line in any way here -- my first pull request, long-time dev, but new here.

davemerrill added some commits Nov 16, 2012
@davemerrill davemerrill Enhance passing of compile options
1. Support passing a subset of compile options to doT.template(). Options not passed default to values in doT.templateSettings.
2. Add an alias for 'argnames' as a compile option, mapping it to varname. Seems more appropriate, since it defines the initial arguments passed into the compiled function.
fb6c048
@davemerrill davemerrill Minified by Google Closure Compiler simple setting c53ca02
@davemerrill davemerrill Update README with info about this fork 6a3f59b
@alltom
alltom commented on 6a3f59b Dec 1, 2012

Thanks.

@davemerrill

Any comments on this? Seemed to me like small but useful changes, no response. I haven't checked if recent version incorporate something similar, but I expect not, given that there's been no action on this PR.

Part 1 is the more important piece IMO.

@olado
Owner
olado commented Sep 7, 2013

Hi Dave,
Thank you for adding this.
I apologize for taking so long to review issues and pull requests. 10 months is a long time, I know.
I have a lot of things going on and at the moment I am only doing bug fixes in doT (like the one yesterday).
I will get back to reviewing all of the pull requests, I hope soon. Sorry!!
Laura

@pke
pke commented Jun 7, 2014

👍 absolutely necessary
Partial options/settings passing is to be expected to work nowadays.

@ZauberNerd ZauberNerd added a commit to ZauberNerd/doT that referenced this pull request Jun 23, 2014
@ZauberNerd ZauberNerd incorporated pull request #51 from original olado/doT repository eae7d2f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.