Remove implicit timezone from time specs #38

Merged
merged 1 commit into from Apr 2, 2012

Conversation

Projects
None yet
2 participants
@dbrady
Contributor

dbrady commented Apr 2, 2012

Hi Kevin!

I made a change to the spec to make them pass in any timezone, but forcing the time comparison to happen in UTC.

  • Changed spec to add getutc to lock specced time to UTC
  • Time.now automagically converts to_local; this means the test suite
    passes in olbrich's timezone but not in the other 23/24ths of the
    Earth ;-)
Make time specs timezone independent
* Changed spec to add getutc to lock specced time to UTC

* Time.now automagically converts to_local; this means the test suite
  passes in olbrich's timezone but not in the other 23/24ths of the
  Earth ;-)
@dbrady

This comment has been minimized.

Show comment Hide comment
@dbrady

dbrady Apr 2, 2012

Owner

Oh--I have emacs set to cleanup whitespace as well; there's a ws edit commingled there. Sorry about that.

Owner

dbrady commented on e10cd0f Apr 2, 2012

Oh--I have emacs set to cleanup whitespace as well; there's a ws edit commingled there. Sorry about that.

@olbrich

This comment has been minimized.

Show comment Hide comment
@olbrich

olbrich Apr 2, 2012

Owner

Thanks!

Owner

olbrich commented Apr 2, 2012

Thanks!

olbrich added a commit that referenced this pull request Apr 2, 2012

Merge pull request #38 from dbrady/master
Remove implicit timezone from time specs

@olbrich olbrich merged commit f600396 into olbrich:master Apr 2, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment