allow temperatures to work when the display name is changed #44

Merged
merged 1 commit into from May 26, 2012

Conversation

Projects
None yet
2 participants
Contributor

twalpole commented May 24, 2012

Some changes so that temperature units are still handled correctly when their display names are changed

olbrich added a commit that referenced this pull request May 26, 2012

Merge pull request #44 from twalpole/temperature_Fixes
allow temperatures to work when the display name is changed

@olbrich olbrich merged commit 52ee093 into olbrich:master May 26, 2012

Owner

olbrich commented May 26, 2012

Good catch, thanks!

olbrich added a commit that referenced this pull request May 27, 2012

* fix specs from issue #44 because they weren't cleaning up properly …
…after themselves

* remove all hard coded temperature handling from unit.rb
* generate regexes required to detect temperatures and degrees
* push temperature conversion routines into procs on the Unit definition.  This makes it possible to introduce arbitrary (and non-linear) temperature scales.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment