Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add WebVTT support #3

Merged
merged 4 commits into from Feb 6, 2019

Conversation

Projects
None yet
2 participants
@JulianKahnert
Copy link
Collaborator

JulianKahnert commented Feb 5, 2019

fixes #2

@ole

This comment has been minimized.

Copy link
Owner

ole commented Feb 5, 2019

Good idea making the test file shorter. At least one test is quite slow with the full file.

@JulianKahnert

This comment has been minimized.

Copy link
Collaborator Author

JulianKahnert commented Feb 5, 2019

Excatly. I wanted to speed up one test, from which I can start writing the parser.
I'd love to here what you think about (first iteration of) the WebVTT struct. Don't mince your words.

I will extend the CLI in the meantime.

btw: I found a way to get the WebVTT files from the Forschergeist Podcast. There are at least those two formats:

@JulianKahnert

This comment has been minimized.

Copy link
Collaborator Author

JulianKahnert commented Feb 5, 2019

Oh, I just saw your implementation von the makeMarkdown() ... I think I was a bit to quick on writing my own.

@JulianKahnert JulianKahnert changed the title [WIP] add WebVTT support add WebVTT support Feb 5, 2019

@ole

This comment has been minimized.

Copy link
Owner

ole commented Feb 6, 2019

Thanks so much for working on this @JulianKahnert. I checked out your code and ran it. The result looks great.

I do have some comments/suggestions on the code, but I'll need some time to write them down. I suggest we'll merge this as-is. We can always make changes later.

@ole ole merged commit 0ca4ffa into ole:master Feb 6, 2019

@ole

This comment has been minimized.

Copy link
Owner

ole commented Feb 10, 2019

@JulianKahnert I sent a PR with some changes (mostly cosmetics and documentation): #5. Nice work!

JulianKahnert added a commit that referenced this pull request Feb 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.