Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GNOME 3.12 compatibility #24

Closed
rhertzog opened this issue Jul 18, 2014 · 2 comments
Closed

GNOME 3.12 compatibility #24

rhertzog opened this issue Jul 18, 2014 · 2 comments

Comments

@rhertzog
Copy link
Contributor

GNOME 3.12 is out and gnome-shell-timer is not compatible with it. I tried updating the metadata but there's more work needed:
Gjs-Message: JS LOG: Extension "timer@olebowle.gmx.com" had error: TypeError: item.addActor is not a function

@rhertzog
Copy link
Contributor Author

Sorry, I was wrong. The code is compatible with GNOME 3.12 (I forgot that the Debian package had a commit reverted to ensure compat with Gnome 3.8). That said there are two warnings emitted:

Gjs-Message: JS WARNING: [/usr/share/gnome-shell/extensions/timer@olebowle.gmx.com/extension.js 146]: assignment to undeclared variable bin
Gjs-Message: JS WARNING: [/usr/share/gnome-shell/extensions/timer@olebowle.gmx.com/extension.js 192]: assignment to undeclared variable item

And you still need to update metadata.json.

@olebowle
Copy link
Owner

fixed, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants