GNOME 3.12 compatibility #24

Closed
rhertzog opened this Issue Jul 18, 2014 · 2 comments

Projects

None yet

2 participants

@rhertzog

GNOME 3.12 is out and gnome-shell-timer is not compatible with it. I tried updating the metadata but there's more work needed:
Gjs-Message: JS LOG: Extension "timer@olebowle.gmx.com" had error: TypeError: item.addActor is not a function

@rhertzog

Sorry, I was wrong. The code is compatible with GNOME 3.12 (I forgot that the Debian package had a commit reverted to ensure compat with Gnome 3.8). That said there are two warnings emitted:

Gjs-Message: JS WARNING: [/usr/share/gnome-shell/extensions/timer@olebowle.gmx.com/extension.js 146]: assignment to undeclared variable bin
Gjs-Message: JS WARNING: [/usr/share/gnome-shell/extensions/timer@olebowle.gmx.com/extension.js 192]: assignment to undeclared variable item

And you still need to update metadata.json.

@olebowle
Owner

fixed, thanks

@olebowle olebowle closed this Jul 23, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment