Notification "Timer finished" should include the name of the "preset" when used #4

Closed
rhertzog opened this Issue Aug 30, 2011 · 3 comments

Projects

None yet

2 participants

@rhertzog

When you fire off a timer based on a preset, it would be nice to include its name in the notification. Something like:
Timer "foo" finished!

@olebowle
Owner

should be fixed in newest commit, thanks for the suggestions

@rhertzog

Works fine, thanks.

One point though: for translations it's very bad to construct one text message with multiple separate translated strings... translation sometimes requires to invert the order of word in a sentence. So you should really use constructs like this: sprintf(gettext("Preset '%s' finished!"), issuer)

It looks like GNOME Shell provides something for this purpose: /usr/share/gnome-shell/js/misc/format.js

String.prototype.format = Format.format;
text = _("Preset '%s' finished!").format(issuer)
@olebowle
Owner

nice spot, i was even able to remove that dodgy 2-digit number transformation

@rhertzog rhertzog closed this Aug 30, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment