Skip to content
This repository

Notification "Timer finished" should include the name of the "preset" when used #4

Closed
rhertzog opened this Issue August 30, 2011 · 3 comments

2 participants

Raphaël Hertzog Ole Ernst
Raphaël Hertzog

When you fire off a timer based on a preset, it would be nice to include its name in the notification. Something like:
Timer "foo" finished!

Ole Ernst
Owner

should be fixed in newest commit, thanks for the suggestions

Raphaël Hertzog

Works fine, thanks.

One point though: for translations it's very bad to construct one text message with multiple separate translated strings... translation sometimes requires to invert the order of word in a sentence. So you should really use constructs like this: sprintf(gettext("Preset '%s' finished!"), issuer)

It looks like GNOME Shell provides something for this purpose: /usr/share/gnome-shell/js/misc/format.js

String.prototype.format = Format.format;
text = _("Preset '%s' finished!").format(issuer)
Ole Ernst
Owner

nice spot, i was even able to remove that dodgy 2-digit number transformation

Raphaël Hertzog rhertzog closed this August 30, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.