Skip to content
This repository has been archived by the owner on Feb 25, 2020. It is now read-only.

Improve buffer-alloc benchmark performance #6

Closed
olegp opened this issue Jun 19, 2011 · 3 comments
Closed

Improve buffer-alloc benchmark performance #6

olegp opened this issue Jun 19, 2011 · 3 comments
Assignees

Comments

@olegp
Copy link
Owner

olegp commented Jun 19, 2011

http://olegp.github.com/common-node/graphs/buffer-alloc.png

Results are far worse than other benchmarks, most likely due to the slow zero() function. Should try using clear from https://github.com/bnoordhuis/node-buffertools/ or drop the requirement to clear the buffer (this would break tests though).

@ghost ghost assigned olegp Jun 19, 2011
@olegp
Copy link
Owner Author

olegp commented Jun 21, 2011

clear() from buffertools was also very slow, so have decided to stick to current zero function

will add an extension to bytearray constructor which will let us create buffers without clearing for performance critical code

@olegp olegp closed this as completed in 7d3cfb1 Jun 21, 2011
@olegp olegp reopened this Sep 22, 2011
@olegp
Copy link
Owner Author

olegp commented Sep 22, 2011

This is not due to clear(), since results without clearing the buffer are the same.

Current benchmark (with clear()) is at http://olegp.github.com/common-node/graphs/buffer-alloc.png

@olegp
Copy link
Owner Author

olegp commented Jan 19, 2012

This was due to use of Object.defineProperty, fixed.

@olegp olegp closed this as completed Jan 19, 2012
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant