Oleg Shaldybin olegshaldybin

Organizations

@apcera
olegshaldybin commented on pull request nats-io/gnatsd#109
olegshaldybin opened pull request nats-io/gnatsd#109
@olegshaldybin
Fix off-by-one in matchLiteral
1 commit with 3 additions and 2 deletions
olegshaldybin deleted branch fix-off-by-one at olegshaldybin/nats
olegshaldybin commented on pull request apcera/util#12
@olegshaldybin

LGTM

olegshaldybin commented on pull request apcera/util#11
@olegshaldybin

LGTM

olegshaldybin commented on pull request apcera/util#11
@olegshaldybin

very minor, but it does double work if includeCredentials is true, can put this into else clause.

olegshaldybin commented on pull request apcera/util#11
@olegshaldybin

I meant the client of this library, not APC client.

olegshaldybin commented on pull request apcera/util#11
@olegshaldybin

Should it be left up to client whether to clear credentials or not?

olegshaldybin commented on pull request apcera/util#10
@olegshaldybin

LGTM

olegshaldybin commented on pull request apcera/util#10
@olegshaldybin

What's the use case for OrderedPieces?

olegshaldybin commented on pull request apcera/util#10
@olegshaldybin

This comment is specific to how Continuum handles things, might not really belong in util package.

olegshaldybin commented on pull request apcera/util#7
@olegshaldybin

Yeah, I think 'chmod' command respects it but syscall might not?

olegshaldybin commented on pull request apcera/util#7
@olegshaldybin

Does umask affect chmod syscall?