From 81ccf41ee9c3ea10a17d3c2cdfd0248df81602d9 Mon Sep 17 00:00:00 2001 From: topstar2023 Date: Thu, 14 Jul 2016 21:27:37 -0700 Subject: [PATCH] [eslint config] [base] [breaking] enable `import/newline-after-import` Per https://github.com/benmosher/eslint-plugin-import/issues/386 / https://github.com/benmosher/eslint-plugin-import/issues/441 --- packages/eslint-config-airbnb-base/package.json | 4 ++-- packages/eslint-config-airbnb-base/rules/imports.js | 3 +-- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/packages/eslint-config-airbnb-base/package.json b/packages/eslint-config-airbnb-base/package.json index 276b685..b1feb14 100644 --- a/packages/eslint-config-airbnb-base/package.json +++ b/packages/eslint-config-airbnb-base/package.json @@ -48,13 +48,13 @@ "babel-tape-runner": "^1.3.1", "eslint": "^3.1.1", "eslint-find-rules": "^1.11.1", - "eslint-plugin-import": "^1.11.0", + "eslint-plugin-import": "^1.11.1", "tape": "^4.6.0", "in-publish": "^2.0.0" }, "peerDependencies": { "eslint": "^3.1.1", - "eslint-plugin-import": "^1.11.0" + "eslint-plugin-import": "^1.11.1" }, "engines": { "node": ">= 4" diff --git a/packages/eslint-config-airbnb-base/rules/imports.js b/packages/eslint-config-airbnb-base/rules/imports.js index d40b54e..99c848c 100644 --- a/packages/eslint-config-airbnb-base/rules/imports.js +++ b/packages/eslint-config-airbnb-base/rules/imports.js @@ -118,8 +118,7 @@ module.exports = { // Require a newline after the last import/require in a group // https://github.com/benmosher/eslint-plugin-import/blob/master/docs/rules/newline-after-import.md - // TODO: enable when https://github.com/benmosher/eslint-plugin-import/issues/386 is resolved - 'import/newline-after-import': 0, + 'import/newline-after-import': 2, // Require modules with a single export to use a default export // https://github.com/benmosher/eslint-plugin-import/blob/master/docs/rules/prefer-default-export.md