Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upHow can Cargo help #63
Comments
This comment has been minimized.
This comment has been minimized.
epage
commented
Jan 16, 2019
#53 and https://github.com/crate-ci/escargot/ have On a related note, |
This comment has been minimized.
This comment has been minimized.
Are you talking about the libtest json output or something different? i.e., today you can get test information with |
This comment has been minimized.
This comment has been minimized.
epage
commented
Jan 16, 2019
|
Was not aware of that unstable feature, thanks! I can understand the challenge of stablizing it. |
This comment has been minimized.
This comment has been minimized.
|
I think sharing the datastructures in a common crate would solve most compatibility issues. If cargo does a backwards compatible change to the datastructures, everyone gets the update for free (via minor bumps), if it's a breaking change, we also bump For the diagnostics json datastructures I also want to push for rustc to share the crates.io datastructures. |
This comment has been minimized.
This comment has been minimized.
dwijnand
commented
Jan 17, 2019
|
A few questions:
So many questions |
This comment has been minimized.
This comment has been minimized.
No, I think they should be versioned by their changes according to semver
Well. I think they should have their own repos, we can publish changes to the datastructure crates before publishing the corresponding cargo change. Of course you can't merge a cargo PR without the datastructure PR having been merged. Experimental things can be added to a |
This comment has been minimized.
This comment has been minimized.
dwijnand
commented
Jan 17, 2019
•
|
Agreed! They should have their own stable versions, and to make cargo and cargo_metadata (and other projects) equal citizens the crates should be in another repo. Cargo's ability to override dependencies with git repos makes this more workable (IMHO). |
This comment has been minimized.
This comment has been minimized.
Eh2406
commented
Jan 23, 2019
|
At the Cargo Team Meeting today we discussed this. The Team is open to pulling the tipes out into a public Crate with a sember based version number! The consensus was to start with a crate that lives in the Cargo repo, instead of having its own repo, at least for now. |
Eh2406 commentedJan 16, 2019
At the Cargo Team Meeting today we discussed the importance of crates like this one. We decided to reach out to discuss how best to work together. How can we insure that the projects are kept smoothly uptodate with each other? What else can the Cargo team do to make sure we don't accidentally break this project? How can the Cargo team make sure that changes get included here promptly? Can we / Should we share code?
cc @ehuss who already got started in #61
and @dwijnand had some suggestions in rust-lang/cargo#6534
Also this idea should be expanded to Cargos other outputs. Should that be done here, or in some other existing crate, or in some new Cargo Team maintained crate?
cc @epage as this relates to the discussion in #45