Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trap focus key navigation in Select Range #4474

Merged
merged 2 commits into from
Apr 28, 2024

Conversation

azmy60
Copy link
Contributor

@azmy60 azmy60 commented Apr 20, 2024

It probably makes more sense if we can always trap the focus when enabling Select Range, IMHO.

I often spam pressing arrow keys if not with ctrl to go to the side of the table. But since tabulator doesn't call .preventDefault at certain condition, it instead does something else to the page. For example, it scrolls the page instead of staying in position, and in my browser, it can go to the previous page (by pressing Ctrl+Left).

To replicate:

This fix can be very helpful too especially if a browser or an app has a custom keybinding. In my browser, I use Ctrl+Left/Right for going to previous/next page. It's annoying that I often accidently change my page when I no longer can go left and I press Ctrl+Left.

@olifolkerd olifolkerd merged commit 44613d2 into olifolkerd:master Apr 28, 2024
1 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants