New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blur rendering broken on Intel 620 #172

Closed
prokoudine opened this Issue Dec 20, 2018 · 12 comments

Comments

Projects
None yet
3 participants
@prokoudine
Copy link
Contributor

prokoudine commented Dec 20, 2018

Any blur effect results in visual garbage both in preview and in the rendered video. I'm on the Intel 620 chipset.

2018-12-20 14-27-51

@itsmattkc itsmattkc added the bug label Dec 20, 2018

@itsmattkc

This comment has been minimized.

Copy link
Contributor

itsmattkc commented Dec 20, 2018

GLSL is notoriously inconsistent depending on the API version/type, driver, OS, etc. so this may be tough to track down. However, if you could send me the output (running from a terminal), that'd be great - it's likely Qt reported an error if it was unable to compile the shader correctly.

@feeef

This comment has been minimized.

Copy link

feeef commented Dec 21, 2018

I have the same issue and the terminal doesn't say much more than :
libpng warning: iCCP: known incorrect sRGB profile

It says that for all filters that I apply but the blur filters are the only ones that don't work as expected. Every other filters work perfectly (and pretty fast) .

I am using mp4 (H.264) rush files.
I have an Intel 520 GPU and I am running Debian testing (if it can help)

@itsmattkc

This comment has been minimized.

Copy link
Contributor

itsmattkc commented Dec 21, 2018

Hmm from the sounds of it, something about the GLSL code in the blurs isn't sitting right with the particular Intel driver(s) that drive these cards. I'll try out Linux on my laptop to see if it's an issue in general with Intel cards on Linux.

@prokoudine

This comment has been minimized.

Copy link
Contributor

prokoudine commented Dec 21, 2018

@itsmattkc

This comment has been minimized.

Copy link
Contributor

itsmattkc commented Dec 21, 2018

@prokoudine Are you also getting no terminal output during runtime? (specifically when adding a blur effect) What about when you compile in debug mode?

@prokoudine

This comment has been minimized.

Copy link
Contributor

prokoudine commented Dec 21, 2018

Are you also getting no terminal output during runtime?

Nothing at all

What about when you compile in debug mode?

That's what I already do -- compile in debug mode :)

@itsmattkc

This comment has been minimized.

Copy link
Contributor

itsmattkc commented Dec 21, 2018

Hmm alrighty, I'll have to look more into this

@itsmattkc

This comment has been minimized.

Copy link
Contributor

itsmattkc commented Dec 21, 2018

I've been able to identify an issue with the blurs affecting Intel GPUs and fixed it in 74d3435. Let me know if this works for you!

@prokoudine

This comment has been minimized.

Copy link
Contributor

prokoudine commented Dec 21, 2018

Looks fixed to me, thanks!

@itsmattkc

This comment has been minimized.

Copy link
Contributor

itsmattkc commented Dec 22, 2018

Awesome, this seems to be a global issue that Intel GPUs had with one of the things I did in the GLSL code as I was able to confirm it in Windows too. Glad it's fixed now!

@itsmattkc itsmattkc closed this Dec 22, 2018

@feeef

This comment has been minimized.

Copy link

feeef commented Dec 26, 2018

It is working on my side too but it is pretty slow and sliding the values can completely freeze the UI...
...but this should be part of another bug :)

@itsmattkc

This comment has been minimized.

Copy link
Contributor

itsmattkc commented Dec 26, 2018

Yeah the blurs could very likely be optimized further (particularly gaussian), I don't think they're as fast as they could be yet.

As the blurs are done on the GPU, I'm not complete sure about whether they can be processed asynchronously (as to not hang the UI), but optimizing them will hopefully at least negate that a little bit in case they can't.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment