New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thumbnails in the Project pane #175

Open
prokoudine opened this Issue Dec 20, 2018 · 9 comments

Comments

Projects
None yet
2 participants
@prokoudine
Copy link
Contributor

prokoudine commented Dec 20, 2018

It would be useful to have optional thumbnail view (next to the current list/table view) in the Project pane for when file names are not human-readable, and previewing each one is not the best option.

@itsmattkc

This comment has been minimized.

Copy link
Contributor

itsmattkc commented Dec 24, 2018

Check out the iconview branch. It should be a fairly complete (right click Project panel > Icon View) but let me know if you have any suggestions. I also realized I could use the thumbnails in the standard Tree View too so I've also done that.

Let me know what you think!

@prokoudine

This comment has been minimized.

Copy link
Contributor

prokoudine commented Dec 24, 2018

project/sourcescommon.h: In constructor ‘SourcesCommon::SourcesCommon(Project*)’:
project/sourcescommon.h:34:14: warning: ‘SourcesCommon::project_parent’ will be initialized after [-Wreorder]
     Project* project_parent;
              ^~~~~~~~~~~~~~
project/sourcescommon.h:31:12: warning:   ‘Media* SourcesCommon::editing_item’ [-Wreorder]
     Media* editing_item;
            ^~~~~~~~~~~~
project/sourcescommon.cpp:19:1: warning:   when initialized here [-Wreorder]
 SourcesCommon::SourcesCommon(Project* parent) :
 ^~~~~~~~~~~~~
project/sourcescommon.cpp: In member function ‘void SourcesCommon::mouseDoubleClickEvent(QMouseEvent*, const QModelIndexList&)’:
project/sourcescommon.cpp:145:56: warning: unused parameter ‘e’ [-Wunused-parameter]
 void SourcesCommon::mouseDoubleClickEvent(QMouseEvent *e, const QModelIndexList& selected_items) {
                                           ~~~~~~~~~~~~~^
project/sourcescommon.cpp: In member function ‘void SourcesCommon::reveal_in_browser()’:
project/sourcescommon.cpp:258:5: error: ‘QDesktopServices’ has not been declared
     QDesktopServices::openUrl(QUrl::fromLocalFile(m->url.left(m->url.lastIndexOf('/'))));
     ^~~~~~~~~~~~~~~~
make: *** [Makefile:2161: sourcescommon.o] Error 1

What do I need to install? :)

@itsmattkc

This comment has been minimized.

Copy link
Contributor

itsmattkc commented Dec 24, 2018

Huh... funnily enough I don't think you have to install anything, I think I just missed an include (interesting that it didn't cause any issues for me). Try the newest commit in iconview :)

@prokoudine

This comment has been minimized.

Copy link
Contributor

prokoudine commented Dec 24, 2018

Builds now, thanks! :)

So, a few ideas for the icon view mode...

  1. Ellipsize long file names.
  2. Always try to show multiple previews in a row (currently just one). Basically, the current preview size slider can control the amount of previews in a row (darktable does that), and their actual size will be computed from 1) width of the project panel, and 2) amount of preview per row. that way, there will be no weird blank spaces to the right of the last preview in the row, and everything will be wrapped around nicely.
  3. You can try to make the iconview more informative while not overloaded. E.g. show clip length next to file name. I think I can make a mockup for you there, if you wish.
@itsmattkc

This comment has been minimized.

Copy link
Contributor

itsmattkc commented Dec 24, 2018

Yes, a mockup of 3 would be helpful I think. The other 2 should be fairly easy to achieve.

@prokoudine

This comment has been minimized.

Copy link
Contributor

prokoudine commented Dec 24, 2018

Here you are :) It's a quick one though

project-bin-mockup

@prokoudine

This comment has been minimized.

Copy link
Contributor

prokoudine commented Dec 24, 2018

There are some behavior considerations here though. E.g. what happens when the preview is too small, because there are too many previews in a row, or the project bin is not too wide? Should Olive figure out when to drop duration (and then file name)? I don't have an answer yet :)

@prokoudine

This comment has been minimized.

Copy link
Contributor

prokoudine commented Dec 24, 2018

Also, the detailed view in the mockup is probably information overload :)

@prokoudine

This comment has been minimized.

Copy link
Contributor

prokoudine commented Dec 25, 2018

Actually, now that I come to think of it, there might be uses for zoom controls in detailed view as well: e.g. show less details (in steps) and less top/bottom padding for wide frames (21:9), or show more details and less left/right padding for 4:3 frames.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment