Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

An exporter should only monitor one host #32

Closed
brian-brazil opened this issue Oct 24, 2016 · 3 comments

Comments

@brian-brazil
Copy link
Contributor

commented Oct 24, 2016

I noticed that the redis exporter has the ability to scrape multiple redis servers, and adds a addr label that partially duplicates the instance label. Per https://prometheus.io/docs/instrumenting/writing_exporters/#deployment there should be a 1-to-1 mapping between exporters and application instances.

@oliver006

This comment has been minimized.

Copy link
Owner

commented Jan 22, 2017

Some folks use the exporter to monitor e.g. an external Azure Redis instance and I'd like to keep that as an option.
I'm also not sure I understand what the actual problem is - the addional addr label?

What is your suggestion to address this?

Maybe drop/not add the addr label when no explicit redis instance address was provided?

@brian-brazil

This comment has been minimized.

Copy link
Contributor Author

commented Jan 22, 2017

Some folks use the exporter to monitor e.g. an external Azure Redis instance and I'd like to keep that as an option.

What I'm suggesting doesn't preclude that.

I'm also not sure I understand what the actual problem is - the addional addr label?

The addr label, and that you allow monitoring more than one redis from one exporter.

@oliver006

This comment has been minimized.

Copy link
Owner

commented Jan 23, 2017

Ok, I see. Well, I like (and use) the ability to monitor more than one Redis instance and it doesn't really cause any harm or trouble so I'd prefer to keep this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.