startupHealthcheck doesn't respect SetHttpClient() #225
Comments
@nickw444 Ah, I see. Sounds like a bug to me. Thanks for reporting. Will take me a few days however; currently on a business trip. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When using
newClient
and providing a custom HTTP client, the connection initiated withinstartupHealthcheck
doesn't use the provided HTTP client, instead, a newhttp.Client
is instantiated, thus any provided HTTP connection configuration is neglected.Offending line appears within
client.go:946
The current use case for this is to provide a self provided CA root cert, which is provided to our
http.Client
. Since the health check does not use this http client, it will fail.The text was updated successfully, but these errors were encountered: