Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TASK] Change locallang XML files to XLIFF and move to language folder #1

Closed
wants to merge 2 commits into from

Conversation

jokumer
Copy link
Contributor

@jokumer jokumer commented Jan 23, 2018

A start to modernize EXT:realty for TYPO3 7 and 8

@oliverklee
Copy link
Owner

Thanks for the PR! I'll review it.

@jokumer
Copy link
Contributor Author

jokumer commented Jan 23, 2018

The wizard for new content elements is broken - can not handle xliff files.

@oliverklee
Copy link
Owner

@jokumer You'll need to update the wizard class like this:
oliverklee/ext-seminars@fcdc26a#diff-4ac504515b5379074ed332e5993f7832

@jokumer
Copy link
Contributor Author

jokumer commented Jan 23, 2018

Perfect hint, thx. I'll implement it

@oliverklee
Copy link
Owner

Merged. Thanks for contributing, @jokumer! ❤️

@jokumer
Copy link
Contributor Author

jokumer commented Jan 24, 2018

And thank you for distributing this extension @oliverklee.

@oliverklee
Copy link
Owner

@jokumer By the way, I think the email address which you've used in the commit is not registered for your GitHub account, i.e., GitHub cannot connect the commit to your account. I propose you either add that email address to you GitHub account, or you change the user.email settings in your local Git installation. (And if you also could put your full name in user.name, that would be perfect so the praise in the Git history really is on you.)

@jokumer
Copy link
Contributor Author

jokumer commented Feb 7, 2018

@oliverklee should we update locallangfiles on translationserver too? https://translation.typo3.org/projects/TYPO3.ext.realty/

@oliverklee
Copy link
Owner

Maybe … honestly, I have no idea how the translation server works, what is automated and what extension authors need to do. Do you know more about this (or have good starting URLs for learning more)?

@jokumer
Copy link
Contributor Author

jokumer commented Feb 8, 2018

I did it once for cal, where it was the same situation: moved xml files to Resources/Private/Language.
It is a bit difficult at some points - but it works. I will do it. More about how it works here https://wiki.typo3.org/Translations

@oliverklee
Copy link
Owner

It is a bit difficult at some points - but it works. I will do it.

Thanks! ❤️

@jokumer
Copy link
Contributor Author

jokumer commented Feb 13, 2018

It is first possible, if the new version has been uploaded to TER. Will have a look at it, after next published release.

@oliverklee
Copy link
Owner

Okay.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants