Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Format buttons in text editor window not working #59

Closed
AngelArnal opened this issue Nov 3, 2016 · 7 comments

Comments

Projects
None yet
6 participants
@AngelArnal
Copy link

commented Nov 3, 2016

Linux Mint 17.3, manuskript-0.3.0-linux-1

Text format buttons (bold, italic, etc) at the bottom of the edit window don't work. No error message, just nothing happens.

@docaltmed

This comment has been minimized.

Copy link

commented Nov 28, 2016

Also in Ubuntu 16.10/Gnome Shell

@olivierkes olivierkes added the bug label Nov 29, 2016

@olivierkes olivierkes modified the milestones: 0.4.0, Future Nov 29, 2016

@olivierkes

This comment has been minimized.

Copy link
Owner

commented Nov 29, 2016

Yep right, i haven't reimplemented yet after i switched from rich text format to markdown.
Need to do.

@Weej1

This comment has been minimized.

Copy link

commented Jun 29, 2017

closed my dupe ticket thing and adding that the keyboard shortcuts Ctrl+B , Ctrl+I, Ctrl+U do not work either. Thanks gedakc for pointing me here!

@darrelwright

This comment has been minimized.

Copy link

commented Nov 14, 2017

Are the formatting options still on the "to-do" list? I see they are still not working in the latest 0.5 development version.

@olivierkes

This comment has been minimized.

Copy link
Owner

commented Nov 14, 2017

Yes, I should do it for the next relases because it's confusing.

Those are the inline formats that could be added:

  • Emphasis: *emphasis* produces emphasis
  • Strong emphasis: **strong emphasis** produces strong emphasis
  • Strikeout: ~~strikeout~~ produces strikeout
  • Superscripts and subscripts: this is ^super^ but this is ~sub~ (github's markdown doesn't support that)
  • Code: `code` produces code
  • Clean format: to remove any formatting

Underline is not supported in markdown.

@olivierkes olivierkes modified the milestones: Future, 0.6.0 Nov 14, 2017

@gedakc

This comment has been minimized.

Copy link
Collaborator

commented Nov 14, 2017

Another thought is to remove the format buttons from Manuskript because adding format using markdown is relatively simple.

@olivierkes olivierkes modified the milestones: 0.6.0, Future Nov 22, 2017

@olivierkes olivierkes modified the milestones: Future, 0.7.0 Nov 30, 2017

olivierkes added a commit that referenced this issue Nov 30, 2017

@olivierkes

This comment has been minimized.

Copy link
Owner

commented Nov 30, 2017

I removed buttons, but added a menu (for those who don't know markdown, and to enable keyboard shortcut):

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.