Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use same function signature for query and mutate functions #55

Merged
merged 1 commit into from Feb 5, 2020
Merged

use same function signature for query and mutate functions #55

merged 1 commit into from Feb 5, 2020

Conversation

loomis
Copy link
Contributor

@loomis loomis commented Feb 5, 2020

In the commit af11689, the function signature for mutate changed from using inline arguments to a single vector argument. This looks to have been an accidental change as the query function still uses inline arguments. This PR changes the mutate function signature to be consistent with the query function.

@oliyh oliyh merged commit fff9596 into oliyh:master Feb 5, 2020
@oliyh
Copy link
Owner

oliyh commented Feb 5, 2020

Hi, thanks for this, it looks like it was a mistake.

I was surprised to see there was no test for the non-re-frame mutate function, I will have to add one.

Cheers

@loomis loomis deleted the fix-mutate-args branch February 5, 2020 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants