Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Can we have a sync version while using as node module? #5

Open
vishr opened this Issue · 2 comments

2 participants

@vishr

No description provided.

@olizilla
Owner

Do you really really need it? asciify loads a file off disk to get the font, so making that sync would tie up the event loop while the disk IO occurred. It's usually a bad idea to force node to do things sync style, so I'm keen to avoid endorsing that, and instead keep this module as simple as possible.

@vishr

The ask is for a sync version along with async and the reason is that my program exists without display the ascii text if there is an error or something similar. I am aware that I can do it in a callback but just thought that it would be nice to have a sync version like we have in the core node library for reading file? I am fine if it's going against the design.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.