Skip to content

Georgian unicode characters #10

Open
wants to merge 1 commit into from

1 participant

@d0ragon
d0ragon commented Jun 14, 2012

Hello there!

I really like your gem and I'm using it for my current task, which is an organization website.
I live in Georgia (country, not the state), so most articles will have Georgian titles.
So the issue that I have is that your gem replaces all Georgian characters with "", and it means that articles' permalink field will be empty.

And what I did was that I added Georgian language compatibility, so it doesn't replace Georgian unicode characters with "".
I just changed this line in lib/friendly_url.rb:
n.gsub!(/[^\sa-z0-9_-]/, '')
to
n.gsub!(/[^\sa-zა-ჰ0-9_-]/, '')
("ა" and "ჰ" are the first and the last characters of Georgian alphabet).

The reason why I'm making a pull request and not just changing the gem on my local is that I'll need to set up this website on the server and if you pull my changes, it'll make my life easier.

Thanks in advance.

@d0ragon d0ragon closed this Jun 14, 2012
@d0ragon d0ragon reopened this Jun 14, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.