New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'check' command #75

Merged
merged 3 commits into from Dec 6, 2017

Conversation

Projects
None yet
2 participants
@brandonhamilton
Contributor

brandonhamilton commented Dec 6, 2017

Resolves #64

@ollef

Hey, and welcome to Sixten!

This looks like a nice and elegant solution to this problem. I only had one question regarding duplication.

Please also feel free to add yourself to the contributors section in the README.

@ollef

I've now added the question about duplication I thought I added previously. I must have forgotten to press the button or something.

optionsParser :: Parser Options
optionsParser = Options
<$> nonEmptySome (strArgument

This comment has been minimized.

@ollef

ollef Dec 6, 2017

Owner

Could this code be shared with the compile options parser (see e.g. how the run command reuses the compile parser)?

@ollef

ollef Dec 6, 2017

Owner

Could this code be shared with the compile options parser (see e.g. how the run command reuses the compile parser)?

This comment has been minimized.

@brandonhamilton

brandonhamilton Dec 6, 2017

Contributor

Yes, agreed. I'll push the relevant change for this 👍

@brandonhamilton

brandonhamilton Dec 6, 2017

Contributor

Yes, agreed. I'll push the relevant change for this 👍

@ollef ollef merged commit 7fb1d3a into ollef:master Dec 6, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ollef

This comment has been minimized.

Show comment
Hide comment
@ollef

ollef Dec 6, 2017

Owner

Great work!

Owner

ollef commented Dec 6, 2017

Great work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment