New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hints to existing rebuses #180

Open
ollelauribostrom opened this Issue Nov 18, 2018 · 5 comments

Comments

Projects
None yet
2 participants
@ollelauribostrom
Owner

ollelauribostrom commented Nov 18, 2018

As of #168 we can now display hints when a user has entered an incorrect answer several times. This is awesome, but almost every rebus is currently lacking the hint property so lets go ahead and add some hints 馃檪

This issue is very beginner friendly, just follow these steps:

  • Open the file src/js/rebuses.js
  • Have a look at the rebuses and see if you can think of any good hints
  • Add your hint to the rebus object: hint: 'Your hint text'
@CodeWithOz

This comment has been minimized.

Contributor

CodeWithOz commented Nov 19, 2018

Not sure this is the appropriate channel (your twitter DMs are not open 馃槥) but I just want to say thank you 馃帀 @ollelauribostrom for this repo. Getting into open source can be so intimidating but this repo really lowers the bar. I am now adding my own Rebus and will try to work on this particular issue. 馃 馃懆鈥嶐煉

@ollelauribostrom

This comment has been minimized.

Owner

ollelauribostrom commented Nov 19, 2018

@CodeWithOz Thanks a lot for the kinds words! Join the gitter channel if you have a questions while submitting your first PR 馃檪

@CodeWithOz

This comment has been minimized.

Contributor

CodeWithOz commented Nov 20, 2018

Thanks! I have submitted the PR. 馃帀 馃檶
I'm working on the hints and I'm just wondering where I should add my commits. Currently, I have the changes in a branch that was created from my uche-new-rebus branch used in the PR. Is that okay? Or would you prefer if I create a new branch from master and add them there?

@CodeWithOz

This comment has been minimized.

Contributor

CodeWithOz commented Nov 20, 2018

Also, I have hints for some but not others. Do you want hints for all of them or just for as many as possible?

@ollelauribostrom

This comment has been minimized.

Owner

ollelauribostrom commented Nov 20, 2018

@CodeWithOz I would prefer it if you created a new branch from master with your new hints. You can just add as many hints as you can think of 馃檪

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment