New: Option to disable tap zones

Author: ollm

CHANGELOG.md

@@ -33,6 +33,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 - Improved extract performance of big files [`5c50739`](https://github.com/ollm/OpenComic/commit/5c507391939c9e56cb1d304df9b3824116de67f4)
 - Support MyAnimeList tracking [`5f40b4a`](https://github.com/ollm/OpenComic/commit/5f40b4af1b70e8cfaad0beb79fec676c9c1c83fe)
 - Multi-layer folder labeling/favoriting and header bar filter options [`652a6a5`](https://github.com/ollm/OpenComic/commit/652a6a522b32fb9bf77a8dbfebafc0496050c634)
+- Option to disable tap zones
 
 ##### 🐛 Bug Fixes
 

languages/ca.json

@@ -359,6 +359,7 @@
 		},
 		"tapZones": {
 			"main": "Zones de toc",
+			"disable": "Desactiva les zones de toc",
 			"leftClick": "Clic esquerre",
 			"rightClick": "Clic dret",
 			"middleClick": "Clic central"

languages/en.json

@@ -359,6 +359,8 @@
 		},
 		"tapZones": {
 			"main": "Tap zones",
+			"disable": "Disable tap zones",
+			"": "",
 			"leftClick": "Left click",
 			"rightClick": "Right click",
 			"middleClick": "Middle click"

languages/es.json

@@ -359,6 +359,7 @@
 		},
 		"tapZones": {
 			"main": "Zonas de toque",
+			"disable": "Desactivar zonas de toque",
 			"leftClick": "Clic izquierdo",
 			"rightClick": "Clic derecho",
 			"middleClick": "Clic central"

scripts/settings.js

@@ -906,6 +906,8 @@ function restoreShortcuts()
 	shortcuts.restoreDefaults();
 
 	generateShortcutsTable(gamepad.currentHighlightItem());
+
+	events.events();
 }
 
 function generateTapZonesTable(list)
@@ -991,15 +993,19 @@ function setTapZone(button, action)
 function getTapZoneActions(button)
 {
 	const list = shortcuts.shortcuts();
-	const actions = [];
+	const actions = [
+		{
+			key: 'disabled',
+			name: language.settings.imageInterpolation.disabled,
+			select: (currentTapZone.tapZone[button].action == 'disabled' ? true : false),
+		},
+	];
 
 	for(let key in list.reading.actionsOrder)
 	{
 		const action = list.reading.actionsOrder[key];
 		const data = list.reading.actions[action];
 
-		console.log(currentTapZone.tapZone[button], button, action);
-
 		actions.push({
 			key: action,
 			name: data.name.replace(/\<br\s*\/?\>/, ' | '),
@@ -1018,6 +1024,8 @@ function restoreTapZones()
 	shortcuts.restoreDefaultsTapZones();
 
 	generateTapZonesTable(shortcuts.shortcuts());
+
+	events.events();
 }
 
 function getImageInterpolationMethods(upscaling = false)
@@ -1449,6 +1457,12 @@ function set(key, value, save = true)
 
 			dom.query('.settings-body .settings-download-opds-folder').class(!value, 'disable-pointer');
 
+			break;
+
+		case 'disableTapZones': 
+
+			dom.query('.settings-body .settings-tap-zones').class(value, 'disable-pointer');
+
 			break;
 	}
 

scripts/shortcuts.js

@@ -36,6 +36,9 @@ function inputIsFocused()
 
 function clickTapZone(event, button)
 {
+	if(config.disableTapZones)
+		return false;
+
 	if(reading.abortClick(event) && button != 'rightClick' && button != 'middleClick')
 		return false;
 
@@ -346,6 +349,14 @@ function loadShortcuts()
 				},
 			],
 			actions: {
+				disabled: { // Disabled action
+					name: language.settings.imageInterpolation.disabled,
+					function: function(event){
+
+						return false;
+
+					},
+				},
 				prev: {
 					name: language.reading.previous,
 					function: function(event){

scripts/storage.js

@@ -1,6 +1,6 @@
 const safe = require(p.join(appDir, 'scripts/storage/safe.js'));
 
-const changes = 114; // Update this if readingPagesConfig is updated
+const changes = 115; // Update this if readingPagesConfig is updated
 
 const readingPagesConfig = {
 	readingConfigName: '',
@@ -163,6 +163,7 @@ const storageDefault = {
 		gamepadDeadZone: 0.1,
 		disableGamepadInput: false,
 		mouseWheelSensitivityInZoom: 10,
+		disableTapZones: false,
 		saveImageTemplate: '[parentFolder] - [folder] - [image] - [page]',
 		saveImageFolder: getDownloadsPath(),
 		saveImageToFolder: false,

templates/settings.content.right.tap.zones.html

@@ -1,6 +1,14 @@
 <h2 class="headline-small">{{language.settings.tapZones.main}}</h2>
 
-<table class="body-large full withoutThead">
+<div class="menu-simple-text gamepad-item">
+	<span>{{language.settings.tapZones.disable}}</span>
+	<div class="switch{{#if config.disableTapZones}} a{{/if}}" on="settings.set('disableTapZones', true)" off="settings.set('disableTapZones', false)">
+		<div></div>
+		<svg viewBox="0 0 52 32"><path d="M 8,0 C 3.58,0 0,3.58 0,8 0,12.42 3.58,16 8,16 8,16 8,16 8,16 12.42,16 16,12.42 16,8 16,3.58 12.42,0 8,0 8,0 8,0 8,0 Z"></path></svg>
+	</div>
+</div>
+
+<table class="body-large full withoutThead settings-tap-zones{{#if config.disableTapZones}} disable-pointer{{/if}}">
 
 	<tbody>
 		{{#each tapZones}}