Fix: Error opening an OPDS Catalog

Author: ollm

CHANGELOG.md

@@ -10,6 +10,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 
 - Error opening files from the system file explorer [`cecc15d`](https://github.com/ollm/OpenComic/commit/cecc15d44c15545fddb932ee87d99213015f295e)
 - Invert tap zones in manga reading [`08a4d10`](https://github.com/ollm/OpenComic/commit/08a4d10115b4687631bd23695d2accff7933ba81)
+- Error opening an OPDS Catalog
 
 ## [v1.5.0](https://github.com/ollm/OpenComic/releases/tag/v1.5.0) (19-06-2025)
 

scripts/dom/labels.js

@@ -40,7 +40,7 @@ async function _opds(url = false, index = false, title = false)
 		const base64 = opds.opds.base64(url);
 		opds.addPathName(base64, title);
 
-		const path = 'opds:/'+base64;
+		const path = 'opds:'+p.sep+base64;
 		await dom.loadIndexPage(true, path, false, false, path);
 	}
 }

scripts/opds.js

@@ -835,12 +835,12 @@ async function boxes(path = false, mainPath = false)
 
 			for(const key in opdsCatalogs)
 			{
-				files.push(...Object.values(opdsCatalogs[key].downloadFiles));
+				files.push(...Object.values(opdsCatalogs[key].downloadFiles ?? {}));
 			}
 		}
 		else
 		{
-			files.push(...Object.values(currentCatalog.downloadFiles));
+			files.push(...Object.values(currentCatalog.downloadFiles ?? {}));
 		}
 
 		const comics = [];

scripts/opds/opds.js

@@ -243,7 +243,7 @@ function convertPublicationsToFile(feed, path, mainPath, currentUrl)
 				const _base64 = base64(resolveUrl(currentUrl, self.href));
 
 				group.mainPath = mainPath;
-				group.path = p.join(path, _base64);
+				group.path = serverClient.fixStart(p.join(path, _base64));
 
 				opds.addPathName(_base64, group.metadata.title);
 			}
@@ -409,7 +409,7 @@ function parseUrls(feed, path, mainPath, currentUrl)
 			const navigation = feed.navigation[i];
 			const _base64 = base64(resolveUrl(currentUrl, navigation.href));
 
-			navigation.path = p.join(path, _base64);
+			navigation.path = serverClient.fixStart(p.join(path, _base64));
 			navigation.mainPath = mainPath;
 			navigation.differentHost = differentHost(currentUrl, navigation.href) ? navigation.href : false;
 
@@ -427,7 +427,7 @@ function parseUrls(feed, path, mainPath, currentUrl)
 			{
 				const _base64 = base64(resolveUrl(currentUrl, pagination.href));
 
-				pagination.path = p.join(p.dirname(path), _base64);
+				pagination.path = serverClient.fixStart(p.join(p.dirname(path), _base64));
 				pagination.mainPath = mainPath;
 
 				opds.addPathName(_base64, opds.pathName(p.basename(path)));
@@ -449,7 +449,7 @@ function parseUrls(feed, path, mainPath, currentUrl)
 					const rel = getRel(link.rel);
 					const _base64 = base64(resolveUrl(currentUrl, link.href));
 
-					link.path = p.join(p.dirname(path), _base64);
+					link.path = serverClient.fixStart(p.join(p.dirname(path), _base64));
 					link.mainPath = mainPath;
 					link.active = rel == 'self' ? true : false;
 
@@ -521,7 +521,7 @@ function getPath(item, currentUrl, mainPath)
 		if(isOpdsCatalog(link.type))
 		{
 			const _base64 = base64(resolveUrl(currentUrl, link.href));
-			link.path = p.join(mainPath, _base64);
+			link.path = serverClient.fixStart(p.join(mainPath, _base64));
 
 			opds.addPathName(_base64, (link.title || link.name || item.title || item.name || opds.pathName(p.basename(mainPath))));
 

scripts/server-client.js

@@ -78,6 +78,12 @@ function fixPath(path)
 	return path.replace(/^(?:\.[\/\\]+)?([a-z0-9]+)\:[\/\\]{1,2}/, '$1:'+p.sep+p.sep);
 }
 
+// Windows only
+function fixStart(path)
+{
+	return path.replace(/^(?:\.[\/\\]+)/, '');
+}
+
 function isDomain(host)
 {
 	return /\./.test(host) ? true : false;
@@ -1770,6 +1776,7 @@ module.exports = {
 	getAdress: getAdress,
 	getTypeAdress: getTypeAdress,
 	fixPath: fixPath,
+	fixStart: fixStart,
 	posixPath: posixPath,
 	servers: function(){return servers},
 	serverLastError: _serverLastError,