New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sonarReport.ProjectName can be not unique #13
base: master
Are you sure you want to change the base?
sonarReport.ProjectName can be not unique #13
Conversation
reportPathsByProject.TryGetValue( | ||
Path.GetFileNameWithoutExtension(projectPath), out var reSharperRoslynFile); | ||
var reSharperRoslynFile = reportPathsByProject | ||
.Single(x => x.Value == Path.GetFileNameWithoutExtension(projectPath)).Key; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's get the variable safely.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed.
Thank you for the contribution! 👍🏻 |
I still have not managed to make all tests green. |
reportPathsByProject.TryGetValue( | ||
Path.GetFileNameWithoutExtension(projectPath), out var reSharperRoslynFile); | ||
var reSharperRoslynFile = reportPathsByProject | ||
.FirstOrDefault(x => x.Value == Path.GetFileNameWithoutExtension(projectPath)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is still unsafe, since there may be null
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
No description provided.