Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc fixes #1

Merged
merged 1 commit into from Nov 6, 2016
Merged

Misc fixes #1

merged 1 commit into from Nov 6, 2016

Conversation

purcell
Copy link
Contributor

@purcell purcell commented Nov 6, 2016

  • Shorter, clearer package description
  • Fix trailing comment position
  • Simpler formulation of drone-root
  • Reformat and fix Commentary section
  • Rename the compilation buffer uniquely

- Shorter, clearer package description
- Fix trailing comment position
- Simpler formulation of drone-root
- Reformat and fix Commentary section
- Rename the compilation buffer uniquely
@olymk2 olymk2 merged commit 1d4ee03 into olymk2:master Nov 6, 2016
@olymk2
Copy link
Owner

olymk2 commented Nov 6, 2016

Thanks a lot for taking the time to make those changes @purcell most appreciated.

@purcell
Copy link
Contributor Author

purcell commented Nov 6, 2016

No problem. Please also test the changes out and let me know if they don't work. In the meantime, I've merged the recipe, so packages will start building on MELPA in the next few hours.

@olymk2
Copy link
Owner

olymk2 commented Nov 6, 2016

Okay thats fantastic, the changes seemed fine i ran it against a random file with no drone.yml in the path.

I also ran it against this package https://github.com/olymk2/emacs-docker-compose with drone and it ran my ert tests just fine, you can expect this plugin in the future but i am still working on it :)

Thanks again for merging the recipe.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants