AuthCanceled should be logged as info instead of error #476

Closed
harph opened this Issue Sep 28, 2012 · 2 comments

Comments

Projects
None yet
2 participants
@harph

harph commented Sep 28, 2012

When the user denies the social auth authorization django-social-auth is logging that as an error, when it isn't. This should be logged as info, because could be useful but it's not actually a problem.

https://github.com/omab/django-social-auth/blob/master/social_auth/decorators.py#L43

@omab

This comment has been minimized.

Show comment Hide comment
@omab

omab Sep 28, 2012

Owner

That decorator will be heavily refactored soon dropping that exception catching and leaving that task just to middleware.

Owner

omab commented Sep 28, 2012

That decorator will be heavily refactored soon dropping that exception catching and leaving that task just to middleware.

@omab

This comment has been minimized.

Show comment Hide comment
@omab

omab Nov 13, 2012

Owner

The refactoring of this decorator was done at adb08ec. The correct method now is to create a middleware class that extends social_auth.middleware.SocialAuthExceptionMiddleware, there you can define the desired behavior for AuthCanceled.

Owner

omab commented Nov 13, 2012

The refactoring of this decorator was done at adb08ec. The correct method now is to create a middleware class that extends social_auth.middleware.SocialAuthExceptionMiddleware, there you can define the desired behavior for AuthCanceled.

@omab omab closed this Nov 13, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment