Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Social Auth v0.7.21 Breaks `pre_update` #624

Closed
kevinastone opened this Issue Mar 6, 2013 · 3 comments

Comments

Projects
None yet
2 participants

I'm not even seeing a branch/tag for the version, but there's a v0.7.21 published on PyPI that's breaking my tests:

from social_auth.signals import pre_update
ImportError: No module named signals

If this is an intentional re-factor, please, for the love of god, increment more than the patch version number! I shouldn't expect code breakage from a patch revision (v0.7.20 -> v0.7.21).

I assume you guys are working on Django 1.5 compatibility, but that should be a new major version, let alone a minor version update.

@omab omab added a commit that referenced this issue Mar 7, 2013

@omab omab Restore signals module. Refs #624 ea0b58c
Owner

omab commented Mar 7, 2013

I've restored the module and drop it out on v0.8, the signals aren't used anymore, and that won't change, replace the code with pipeline methods where needed. Take into account that DSA is not flagged as stable and its API can and will change if needed, but I agree that some changes should be done paying more attention.

@omab omab closed this Mar 7, 2013

No problem. Figured that, just wasn't ready for a re-factor in such a small revision.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment