Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

It fixes losing of "access" or "refresh" tokens issue #767

Merged
merged 1 commit into from Sep 6, 2013

Conversation

Projects
None yet
2 participants
Contributor

marselester commented Sep 6, 2013

Let's assume that we have just signed in with GitHub:

>>> github_user.extra_data
{u'access_token': u'my access token', u'expires': None, u'id': 666}
>>> github_user.refresh_token()
>>> github_user.extra_data
{u'access_token': '', u'expires': None, u'id': None}

GitHub responded {u'error': u'bad_verification_code'} and refresh_token() lost access_token, id.

One more example:

>>> odnoklassniki_user.extra_data
{u'access_token': u'my access token', u'expires': None, u'refresh_token': u'my refresh token'}
>>> odnoklassniki_user.refresh_token()
>>> odnoklassniki_user.extra_data
{u'access_token': u'new access token', u'expires': None, u'refresh_token': None}
>>> odnoklassniki_user.refresh_token()
>>> odnoklassniki_user.extra_data
{u'access_token': '', u'expires': None, u'refresh_token': None}

Odnoklassniki responded {u'access_token': u'new access token', u'token_type': u'session'} and refresh_token() lost refresh_token and then access_token.

omab added a commit that referenced this pull request Sep 6, 2013

Merge pull request #767 from marselester/master
It fixes losing of "access" or "refresh" tokens issue

@omab omab merged commit abb511f into omab:master Sep 6, 2013

Owner

omab commented Sep 6, 2013

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment