/python-social-auth

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Django 1.10 deprecation warnings #806

Merged
merged 1 commit into from Jan 14, 2016

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@yprez @alexandrevicenzi @gustavi @omab
@yprez
Contributor

yprez commented Dec 16, 2015

In django_app/urls.py:

  • Use a list instead of patterns
  • Use view callables instead of strings

Fixes #804, #754
@yprez
Fix Django 1.10 deprecation warnings 
In django_app/urls.py:
* Use a list instead of `patterns`
* Use view callables instead of strings

Fixes #804, #754
eca0f26
@alexandrevicenzi

This comment has been minimized.

Show comment
Hide comment
@alexandrevicenzi

alexandrevicenzi Dec 23, 2015

👍

alexandrevicenzi commented Dec 23, 2015

👍

@contracode contracode referenced this pull request Dec 30, 2015

Merged

Fix Django 1.10 Deprecation Warning "SubfieldBase has been deprecated." #813

@gustavi gustavi referenced this pull request Jan 6, 2016

Closed

Passage à Django 1.9 #3245

0 of 4 tasks complete
@gustavi

This comment has been minimized.

Show comment
Hide comment
@gustavi

gustavi Jan 7, 2016

The code is OK, somebody can merge it ?

gustavi commented Jan 7, 2016

The code is OK, somebody can merge it ?
@yprez

This comment has been minimized.

Show comment
Hide comment
@yprez

yprez Jan 7, 2016

Contributor

@omab there are several PRs addressing this and other compatibility issues, is there any chance you can review/merge/close some of them?
Contributor

yprez commented Jan 7, 2016

@omab there are several PRs addressing this and other compatibility issues, is there any chance you can review/merge/close some of them?
@gustavi

This comment has been minimized.

Show comment
Hide comment
@gustavi

gustavi Jan 10, 2016

Some news ?

gustavi commented Jan 10, 2016

Some news ?
@omab

This comment has been minimized.

Show comment
Hide comment
@omab

omab Jan 10, 2016

Owner

Will take a look asap.
Owner

omab commented Jan 10, 2016

Will take a look asap.
@gustavi

This comment has been minimized.

Show comment
Hide comment
@gustavi

gustavi Jan 14, 2016

?

It's just a code review, please merge it ASAP.

gustavi commented Jan 14, 2016

?

It's just a code review, please merge it ASAP.

@omab omab merged commit eca0f26 into omab:master Jan 14, 2016
1 check passed

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@omab

This comment has been minimized.

Show comment
Hide comment
@omab

omab Jan 14, 2016

Owner

Thanks @yprez, merged.

@gustavi it's not just "code review", and it also takes time.
Owner

omab commented Jan 14, 2016

Thanks @yprez, merged.

@gustavi it's not just "code review", and it also takes time.
@gustavi

This comment has been minimized.

Show comment
Hide comment
@gustavi

gustavi Jan 14, 2016

Thank you.

gustavi commented Jan 14, 2016

Thank you.
@yprez

This comment has been minimized.

Show comment
Hide comment
@yprez

yprez Jan 14, 2016

Contributor

Thanks @omab !

I'll try fixing the other deprecation issues, or finding PRs that already do...
Contributor

yprez commented Jan 14, 2016

Thanks @omab !

I'll try fixing the other deprecation issues, or finding PRs that already do...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment