Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support encrypted query signatures #15

Closed
jamesqo opened this issue Aug 31, 2015 · 4 comments
Closed

Support encrypted query signatures #15

jamesqo opened this issue Aug 31, 2015 · 4 comments

Comments

@jamesqo
Copy link
Collaborator

jamesqo commented Aug 31, 2015

Right now we don't support encrypted signatures in the URL query when extracting the link from YouTube. This can lead to 403 errors when downloading the video, which could be the cause of #8.

YoutubeExtractor already handles this problem, so it shouldn't be too hard to refactor the code from there and implement this.

@i3arnon
Copy link
Collaborator

i3arnon commented Aug 31, 2015

@jamesqo Just a note about the implementation:
YE enables getting all the urls encrypted (by passing false) and explicitly decrypting specific ones.
This is a good paradigm as it can improve performance significantly.

@terrybrash
Copy link

Currently porting my application over to libvideo and ran into this problem. How's progress? I can work on it if you haven't started yet.

@jamesqo
Copy link
Collaborator Author

jamesqo commented Sep 13, 2015

@inlinevoid Working on it, but I should be finished within a day or two. I'll let you know when I've made the change.

Thanks for the offer, by the way!

@jamesqo
Copy link
Collaborator Author

jamesqo commented Sep 19, 2015

This is finally supported: 7dadee8. Unfortunately I renamed some of the classes in the new version as well (changelog), so you may have to do a find-and-replace for them.

Thanks for your support, let me know if you guys have any problems!

@jamesqo jamesqo closed this as completed Sep 19, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants