Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Youtube comments suggestion #132

Closed
dimqua opened this issue Aug 28, 2018 · 7 comments

Comments

@dimqua
Copy link
Contributor

commented Aug 28, 2018

You can make youtube comments on the site look more youtube-like by placing the publishing date and the number of likes to the bottom of users comments.
This is an example from SkyTube app:

And probably there is no need for +/- buttons, at least for YouTube comments.

@omarroth

This comment has been minimized.

Copy link
Owner

commented Aug 30, 2018

Looks good!

As for +/-, it looks to me like it would be replaced by a hide replies. Should they be removed for another reason?

@omarroth

This comment has been minimized.

Copy link
Owner

commented Oct 6, 2018

Added with 650b44a.

@omarroth omarroth closed this Oct 6, 2018
@dimqua

This comment has been minimized.

Copy link
Contributor Author

commented Oct 9, 2018

As for +/-, it looks to me like it would be replaced by a hide replies.

You can't hide all the replies by using +/-, while keeping the original post visible.

@Jtasiu

This comment has been minimized.

Copy link

commented Oct 10, 2018

Added with 650b44a

@omarroth I think this made comments stop showing anymore whenever JS is disabled. Is there some way to still show comments when JS is off like it was before?

@omarroth

This comment has been minimized.

Copy link
Owner

commented Oct 10, 2018

Reddit comments have used JS since c7a46cd, and YouTube comments have used JS since they were added with 1eb7066. The reason why is because comments were the largest source of latency for loading the /watch page, adding about 3 seconds, so they were split off into a separate request.

It might be possible to try to reintegrate them back into the initial page load, but obviously it would reintroduce that issue. You also wouldn't be able to view replies to comments, or minimize YouTube or Reddit comments, since that functionality also uses JS.

If you'd like to download comments for offline viewing or for use in another application, you can with /api/v1/comments/:videoID. Here's an example, and more info is available about that here.

I think it's unfortunate that JS is necessary, and obviously I would prefer that it wasn't (the way it was originally), but I hope I was able to explain why it currently works the way it does, sorry I couldn't be more help.

@Jtasiu

This comment has been minimized.

Copy link

commented Oct 11, 2018

I see. Is the latency a problem for the user or the server? If it's on user side I think those with JS off wouldn't mind a few extra seconds. If you can somehow show comments back in the initial page load that would be amazing it was a great feature. I could also view replies to comments even when JS was off. Would noscript tags be able to do something here? Or some way to have comments in initial page load if JS off is detected and the way it is now if JS is detected on?

@dimqua

This comment has been minimized.

Copy link
Contributor Author

commented Oct 11, 2018

those with JS off wouldn't mind a few extra seconds

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.