Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DASH video corruption seemingly at random #193

Open
Discookie opened this issue Sep 29, 2018 · 4 comments

Comments

@Discookie
Copy link

commented Sep 29, 2018

I've been watching DASH videos, and this is the second time I've had a corrupted video like this one.

image

There's sometimes a full-screen color change, but otherwise only the top few rows change.

image

It looks like the video files are somehow misaligned? It might come from proxying dropping a bit of data, or from a bug in the DASH player. A refresh fixes it, and usually after a minute or so it fixes itself.

I couldn't find a way to reproduce this issue reliably, but here's the link anyways:
https://invidio.us/watch?v=-LytcXun4hU

I've had this issue on 2 separate machines, on Waterfox 56.2.3 on Win10/AMD and a Chromium 69.0 on Win8.1/Nvidia.

@omarroth

This comment has been minimized.

Copy link
Owner

commented Sep 30, 2018

Does it reliably happen ~x seconds into the video? It might be the case that Invidious is generating a bad manifest that results in an incorrect offset like what appears to be encountered. Does devtools show any errors?

Currently, Invidious uses videojs/videojs-contrib-dash, because videojs/http-streaming does not yet support features that Invidious uses in its manifests. I suspect the issue is in the player since it disappears after a refresh, and I think this issue will likely go away after switching to http-streaming.

@Discookie

This comment has been minimized.

Copy link
Author

commented Oct 4, 2018

Found a semi-reliable way to reproduce it, and it looks more like a player issue:
Simply jump forward with the arrows to the very end of the buffer.
If you get unlucky, your video will corrupt the same way.

dash.mediaplayer.min.js throws this warning:

[496953][Stream] onBufferingCompleted - can't trigger STREAM_BUFFERING_COMPLETED because streamProcessor audio is not buffering completed

The audio and the corrupted video continued without interruption.

A potential fix would be to stop the video and wait for buffer ~1s before the end of the buffer?

@omarroth omarroth added the bug label Oct 13, 2018
@omarroth

This comment has been minimized.

Copy link
Owner

commented Apr 28, 2019

Switched over to http-streaming with 075adb4 which should hopefully resolve this issue.

@Discookie

This comment has been minimized.

Copy link
Author

commented Apr 30, 2019

Encountered it the very first time I tried to switch resolutions with the new source selector :/

Although it's starting to smell more like hardware issues, because Streamable's being corrupted on the AMD machine too. GPU/decode stress testing didn't report anything so far, but I'll keep testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.