Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Post/exit calls #154

Merged
merged 8 commits into from Sep 12, 2018

Conversation

Projects
None yet
4 participants
@etagwerker
Copy link
Member

etagwerker commented Sep 12, 2018

Hey @lubc @ercohen14 @mauro-oto,

I just wrote an article about our exit calls. Please check it out and let me know.

Thanks!

@etagwerker etagwerker requested review from mauro-oto , lubc and ercohen14 Sep 12, 2018

@lubc

lubc approved these changes Sep 12, 2018

Copy link
Member

lubc left a comment

@etagwerker Looks good! I added one small comment at the end


Our secret sauce for our productized [Rails upgrade service](https://fastruby.io) ([https://fastruby.io](https://fastruby.io))
is constantly changing, getting better with every project we ship. Exit calls are
the best way to keep getting better.

This comment has been minimized.

@lubc

lubc Sep 12, 2018

Member

@etagwerker Just to not repeat getting better, maybe something like Exit calls are the best way to keep improving as a company sound better?

This comment has been minimized.

@etagwerker

etagwerker Sep 12, 2018

Author Member

Much better. Thanks!

@mauro-oto
Copy link
Contributor

mauro-oto left a comment

Looks good! Left one comment for the opening line.

author: "etagwerker"
---

At Ombu Labs we believe that if we are not learning from your mistakes we are

This comment has been minimized.

@mauro-oto

mauro-oto Sep 12, 2018

Contributor

I think you meant to say "if we are not learning from our mistakes" instead.

This comment has been minimized.

@etagwerker

etagwerker Sep 12, 2018

Author Member

@mauro-oto Good point. I had started with you and then I decided to change to we -- I missed that!

- What did you _like_ about our service?

- What did you _hate_ about our service?

This comment has been minimized.

@ercohen14

ercohen14 Sep 12, 2018

Contributor

Maybe this could be "what did you dislike" instead of hate.

@etagwerker

This comment has been minimized.

Copy link
Member Author

etagwerker commented Sep 12, 2018

@lubc @mauro-oto @ercohen14 Thanks for your feedback! I just updated this article: 9f93375

@lubc

This comment has been minimized.

Copy link
Member

lubc commented Sep 12, 2018

@etagwerker Cool! Looks good to me 👍

@etagwerker etagwerker merged commit eb8438c into master Sep 12, 2018

@etagwerker etagwerker deleted the post/exit-calls branch Sep 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.