Skip to content
This repository has been archived by the owner on Feb 18, 2021. It is now read-only.

Exploring Method's Arguments Part 3 #422

Merged
merged 5 commits into from May 5, 2020
Merged

Exploring Method's Arguments Part 3 #422

merged 5 commits into from May 5, 2020

Conversation

arielj
Copy link
Member

@arielj arielj commented Apr 23, 2020

This PR adds the third part of the series. I also updated the previous articles with links to the next one.

Copy link
Member

@FionaDL FionaDL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@arielj looks good, just a few comments on grammar.

_posts/2020-04-18-methods-arguments-ruby-bart3.markdown Outdated Show resolved Hide resolved
_posts/2020-04-18-methods-arguments-ruby-bart3.markdown Outdated Show resolved Hide resolved
_posts/2020-04-18-methods-arguments-ruby-bart3.markdown Outdated Show resolved Hide resolved
_posts/2020-04-18-methods-arguments-ruby-bart3.markdown Outdated Show resolved Hide resolved
_posts/2020-04-18-methods-arguments-ruby-bart3.markdown Outdated Show resolved Hide resolved
_posts/2020-04-18-methods-arguments-ruby-bart3.markdown Outdated Show resolved Hide resolved

## Conclusion

So we have covered more ways to make our methods super flexible so the user can use them and also customize the behavior to its needs.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is sentence is a little confusing. Who is the user here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I meant the person that's using the method.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe:
We have covered more ways to make our methods super flexible so that we can use the methods and customize their behavior to our needs.

You have used "we" most of the time throughout the article so I think it is smoother.

_posts/2020-04-18-methods-arguments-ruby-bart3.markdown Outdated Show resolved Hide resolved
Copy link
Contributor

@lubc lubc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@arielj Great article! I just added a few small comments

_posts/2020-04-18-methods-arguments-ruby-bart3.markdown Outdated Show resolved Hide resolved
_posts/2020-04-18-methods-arguments-ruby-bart3.markdown Outdated Show resolved Hide resolved
_posts/2020-04-18-methods-arguments-ruby-bart3.markdown Outdated Show resolved Hide resolved
_posts/2020-04-18-methods-arguments-ruby-bart3.markdown Outdated Show resolved Hide resolved
_posts/2020-04-18-methods-arguments-ruby-bart3.markdown Outdated Show resolved Hide resolved
@arielj
Copy link
Member Author

arielj commented May 5, 2020

@lubc done

@arielj arielj requested a review from lubc May 5, 2020 14:04
@lubc lubc merged commit b8a41c9 into master May 5, 2020
@lubc lubc deleted the post/method-arguments-3 branch May 5, 2020 15:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants