-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gradle build #12
Gradle build #12
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, looks very nice. A few stylistic comments about the JSON file.
Do you have a shortlist of the candidate repositories for rolling this template over? Have you pretested it on a few of them already?
{ | ||
"name": "Build using Gradle", | ||
"description": "Build using Gradle, by default version 5.2.1 is used.", | ||
"iconName": "gradle" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- proposing to add
Gradle
and/orJava
as theCategories
- see https://github.com/github/linguist/blob/master/lib/linguist/languages.yml - can we make assumptions about the
filePatterns
e.g.build.gradle
or*.gradle
in the top-level folder?
filePatterns
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
build.gradle is in the top-level folder of our repositories.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added Categories
and filePatterns
I have tested it on https://github.com/jburel/omero-model/actions/runs/366626900 |
Other Gradle repos I am aware of are:
I can have a go at testing the two first ones next week. Unsure whether the latter will need a separate logic |
I was considering omero-gradle-plugins as part of the decoupled effort, I have been looking at the repo for other purpose i.e. upgrading gradle I will check example repo today |
minimal-omero-client: a Dockerfile is used to run gradle build |
For bio-formats-example: we have a combination of Java version and there is windows attempt. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes. Happy for this to be added to the templates as it is and start rolling it over to the various Gradle repositories unless @joshmoore thinks of something else.
Looks good. There may still be some repositories with wrapper logic and/or hard-coded versions in various repos that don't like being told what version to use, but we can deal with those by stripping out those assumptions. 👍 |
Build application using gradle
By default 5.2.1 version is used. This is the version currently used in the various gradle projects.