Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gradle build #12

Merged
merged 4 commits into from
Nov 18, 2020
Merged

Gradle build #12

merged 4 commits into from
Nov 18, 2020

Conversation

jburel
Copy link
Member

@jburel jburel commented Nov 16, 2020

Build application using gradle
By default 5.2.1 version is used. This is the version currently used in the various gradle projects.

Copy link
Member

@sbesson sbesson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, looks very nice. A few stylistic comments about the JSON file.

Do you have a shortlist of the candidate repositories for rolling this template over? Have you pretested it on a few of them already?

{
"name": "Build using Gradle",
"description": "Build using Gradle, by default version 5.2.1 is used.",
"iconName": "gradle"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As per https://docs.github.com/en/free-pro-team@latest/actions/learn-github-actions/sharing-workflows-with-your-organization#creating-a-workflow-template:

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

build.gradle is in the top-level folder of our repositories.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added Categories and filePatterns

@jburel
Copy link
Member Author

jburel commented Nov 18, 2020

I have tested it on https://github.com/jburel/omero-model/actions/runs/366626900
This will be applied to most of the repositories created when we decoupled openmicroscopy.
A couple will require some adjustments e.g. omero-blitz

@sbesson
Copy link
Member

sbesson commented Nov 18, 2020

Other Gradle repos I am aware of are:

  • bio-formats-examples
  • minimal-omero-client
  • omero-gradle-plugins

I can have a go at testing the two first ones next week. Unsure whether the latter will need a separate logic

@jburel
Copy link
Member Author

jburel commented Nov 18, 2020

I was considering omero-gradle-plugins as part of the decoupled effort, I have been looking at the repo for other purpose i.e. upgrading gradle

I will check example repo today

@jburel
Copy link
Member Author

jburel commented Nov 18, 2020

minimal-omero-client: a Dockerfile is used to run gradle build

@jburel
Copy link
Member Author

jburel commented Nov 18, 2020

For bio-formats-example: we have a combination of Java version and there is windows attempt.
Both cases are covered by the template

Copy link
Member

@sbesson sbesson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes. Happy for this to be added to the templates as it is and start rolling it over to the various Gradle repositories unless @joshmoore thinks of something else.

@joshmoore
Copy link
Member

Looks good. There may still be some repositories with wrapper logic and/or hard-coded versions in various repos that don't like being told what version to use, but we can deal with those by stripping out those assumptions. 👍

@sbesson sbesson merged commit 15a4b21 into ome:master Nov 18, 2020
@sbesson
Copy link
Member

sbesson commented Nov 18, 2020

Screenshot 2020-11-18 at 13 37 11 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants