Leica LIF: fix support for new files with 0 padding (rebased onto dev_5_0) #1399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
--rebased-from #1382 |
|
https://ci.openmicroscopy.org/view/5.0/job/BIOFORMATS-5.0-merge-full-repository/ is green and all the datasets from #1382 look fine. I'd say this is good to merge. |
|
Hi, is this fix now in the current developer version on bio-formats? Also how do I build the newest version after downloading zip? |
melissalinkert
added a commit
that referenced
this pull request
Nov 4, 2014
…a-lif Leica LIF: fix support for new files with 0 padding (rebased onto dev_5_0)
|
@sinclaircooper: builds containing this fix can be downloaded from: https://ci.openmicroscopy.org/view/Bio-Formats/job/BIOFORMATS-5.0-latest/lastSuccessfulBuild/artifact/artifacts/ If you downloaded the source Zip from Github or |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the same as gh-1382 but rebased onto dev_5_0.
Fixes http://trac.openmicroscopy.org.uk/ome/ticket/12144. With this change, files in
leica-lif/fabrice/new,leica-lif/ron/, and QA 9457 should all open/import without throwing an exception, and there should be nothing obviously wrong with the images and metadata.All other files should not be affected, so builds should remain green.