Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only override the file name for non-local files #153

Merged
merged 1 commit into from
Sep 20, 2012

Conversation

melissalinkert
Copy link
Member

@melissalinkert
Copy link
Member Author

To test, verify that opening a file in ImageJ/Fiji and running the macro getInfo("image.filename") returns only the relative path. Also, it's worth double-checking that #9440 hasn't resurfaced as a result.

I've tested both things and they do check out for me.

@melissalinkert
Copy link
Member Author

options.isLocal() returns true when reading directly from a local file on disk (i.e. not from OMERO).

@joshmoore
Copy link
Member

Built locally. Both local file via "Plugins > LOCI > Bio-Formats Importer" and "OMERO > Connect to OMERO" look fine.

@joshmoore
Copy link
Member

As mentioned offline, the only I can think to add is that once we have the infrastructure in place, it would be good to add a test for this behavior in case isLocal or similar every changes. Perhaps a single list somewhere of all the various things that we could/would eventually need tests for would be useful.

joshmoore added a commit that referenced this pull request Sep 20, 2012
Only override the file name for non-local files
@joshmoore joshmoore merged commit 40dcfdb into ome:develop Sep 20, 2012
hflynn pushed a commit to hflynn/bioformats that referenced this pull request Oct 11, 2013
Fixing Win OMERO.server installation web format
melissalinkert pushed a commit to melissalinkert/bioformats that referenced this pull request Jan 11, 2018
OME-TIFF: try harder to preserve metadata when files are ungrouped
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants