fake: allow injecting sleep on setId and openBytes #3422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbesson
approved these changes
Sep 20, 2019
There was a problem hiding this comment.
Generally, quite enthusiastic to see more logic integrated into our mock/fake reader to simulate various typical behaviors of the readers. Apart from timeout/latencies, another feature I have been considering at times is being able to throw specific exceptions during a given stage, probably setId and openBytes as primary candidates.
Happy to see this merged in its current form and the keys added to the documentation unless you have more work coming.
|
Merging this as is, i'll make a note to update the documentatn on Monday |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Opening to debug an ongoing timeout issue. May expand into a (developer) feature.