Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AmiraParameters: Use warning for empty key #3435

Open
wants to merge 1 commit into
base: develop
from

Conversation

@dgault
Copy link
Member

commented Sep 10, 2019

This is an initial test PR for an issue reported on https://forum.image.sc/t/error-importing-am-files-bio-formats/29358

A sample file is expected via ftp which will be used for further testing.

@@ -380,7 +385,11 @@ protected Map readMap() throws FormatException, IOException {
}

String key = readKey();
if (key.equals("")) syntaxError("Invalid key");
if (key.equals("")) {
LOGGER.warn("Syntax warning:" + row + ":" + column + ": " + "Invalid key");

This comment has been minimized.

Copy link
@joshmoore

joshmoore Sep 10, 2019

Member

Not that it needs doing in this PR, but I can see this being wrapped into a helper method managed by a metadata option to choose between strict and lenient behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.