Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JPEG2000 reader: add full support for sub-resolutions #3445

Open
wants to merge 4 commits into
base: develop
from

Conversation

@sbesson
Copy link
Member

commented Sep 26, 2019

The JPEG2000 codec logic has full support for sub-resolution and is used in a couple of places in this code as well as consumers. I realized recently that this is not exposed at the level of the JPEG2000 file format reader so all .jp2 images are read as single-resolution at the moment.

5e5606c updates the reader to pass the resolutionLevels detected by the metadata parser. This will impact the configuration files for all JPEG200 which will need to be regenerated.
4a50653 is not strictly necessary but addresses the long-standing problem of the file ordering when regenerating configuration files /cc @melissalinkert

Without this PR, running showinf on JPEG2000 files should show no additional series/sub-resolutions depending on -noflat. Importing large JPEG2000 images into OMERO should generate pyramids.

With this PR, showinf should display series/sub-resolutions and OMERO should read sub-resolutions natively from the image i.e. no pyramid generation step in the UI/logs.

  • jpeg200/david/cy5-tph.jp2
  • jpeg2000/big-images/8kx8k.jpf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.