CZI: Pad scene number and switch to 1 indexed #3610
Conversation
|
This pull request has been mentioned on Image.sc Forum. There might be relevant details there: https://forum.image.sc/t/scene-numbering-in-omero-from-multi-scene-czi-files/41794/2 |
|
An additional sample file is now available in QA-29487. This file should also be tested and configured as part of this PR. |
There was a problem hiding this comment.
The code change is absolutely straightforward and makes sens
Loading the sample file without this PR produces
With this PR included, all image names are padded with zeros as expected
The only downside of this change is whether we anticipate the padding/indexing change would lead to breakages in script parsing the name. In this case, the naming behavior could optionally be controlled via options.
Otherwise, this looks good to merge once the sample file has been configured and added to the daily non-regression tests.
|
Builds and tests continue to pass with the latest sample file included. Merging for 6.6.0 |
This request was raised in forum thread https://forum.image.sc/t/scene-numbering-in-omero-from-multi-scene-czi-files/41794
The PR switches the image name which is Scene #0, Scene #1 etc to be 1 indexed. It also adds zero padding when necessary.
As far as I can find we only have 2 datasets in the repo which use this scene number and unfortunately both only have a single digit number of scenes.
To test you can use either of the below:
The updated value can be seen when viewing the Image Name in the OME-XML using (note noflat must be set) :
showinf -noflat -nopix -omexml path/to/file.czi