Sprint12 bug fixes #54
Conversation
And while we're at it, do not populate the relative timestamps if SizeT is 1. Timestamps in this context are not the actual acquisition timestamps, but rather the position within a timelapse movie. See #8323.
Patch submitted by Dave Harvey via Charles Brossollet, with minor whitespace changes applied. Closes #7990.
There is a performance penalty for constructing DocumentBuilder objects. We can mitigate this by waiting to construct the DocumentBuilder until a method is called which requires it, instead of constructing it in AbstractOMEXMLMetadata's constructor.
'.dv' is also used by DV-DIF files, which is an entirely different format from Deltavision. Reported by Christian Dietz.
See #6189.
TIFF files that belong to CellWorX datasets often have the same distinguishing metadata as Metamorph TIFFs. To prevent type detection errors, we now have the Metamorph reader reject any TIFF files that have an .htd file in the same directory.
Hopefully fixes #6189.
|
Finally added testing notes. @rleigh-dundee, if you have some time to go through the tests here, it would be much appreciated (note that most of it is just automated testing, so it shouldn't take too much focused time). |
|
The 'cellworx' failures will have been a repository configuration issue, which has just now been fixed. |
|
On 20/04/2012 14:52, Melissa Linkert wrote:
OK, I'll repeat as soon as the metamorph tests complete. Thanks. The University of Dundee is a registered Scottish Charity, No: SC015096 |
I can't duplicate this, having checked out and built against the branch head. Were you building against one specific commit? If so, please do try from the branch head - there were two separate commits to the Zeiss .czi reader that fixed separate test failures, so having one and not the other will still allow the tests to fail. |
|
On 20/04/2012 17:13, Melissa Linkert wrote:
This was tested from the branch head. I'm testing again just to be -----commit-test------ set -e DATA=~/images ant clean jars ant -Dtestng.directory="$DATA/$IMAGES" -Dtestng.memory=2048m test-automatedAnd running "commit-test zeiss-czi" in the checked out source tree. AFAICS this matches the instructions on the commit testing web page. The University of Dundee is a registered Scottish Charity, No: SC015096 |
|
Not using --delete with rsync appears to have solved the test failures I was experiencing. I ran the zeiss-czi tests successfully overnight. Running metamorph now. |
|
Based on discussion with Melissa, merging so that we will have this available for testing tomorrow morning. If there are any issues, @rleigh-dundee, still comment here and we can re-open and merge in again. |
Limitations update (webstart etc)
Fixes for various bugs reported over the course of sprint 12. Testing notes forthcoming.